fix(cdk/portal): run change detection before inserting portal content #20346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
portal-timing
branch
from
1a7a1a2 to
27dcbe2
Compare
crisbeto
force-pushed
the
portal-timing
branch
from
27dcbe2 to
bb30690
Compare
crisbeto
changed the title
crisbeto
force-pushed
the
portal-timing
branch
from
bb30690 to
47c37b2
Compare
crisbeto
force-pushed
the
portal-timing
branch
from
bc75a42 to
16bc2d3
Compare
In angular#16407 we made some changes where we'd run change detection after transferring the portal content to the outlet, in order to handle a case where focus traps may be attached too early. This PR reverts back to triggering change detection before moving the content, because doing it after may leave behind nodes that were inserted through `ViewContainerRef` inside one one of the init hooks. The initial focus trap issue is resolved by delaying the attachment instead. These changes fix another issue where we were assuming that component portals can only have one root node. This is true for most cases, except for when a sibling is inserted through `ViewContainerRef`. Fixes angular#20343.
crisbeto
force-pushed
the
portal-timing
branch
from
16bc2d3 to
6f3b5db
Compare
andrewseguin
removed
the
cla: yes
josephperrott
added
action: cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16407 we made some changes where we'd run change detection after transferring the portal content to the outlet, in order to handle a case where focus traps may be attached too early. This PR reverts back to triggering change detection before moving the content, because doing it after may leave behind nodes that were inserted through
ViewContainerRefinside one one of the init hooks. The initial focus trap issue is resolved by delaying the attachment instead.These changes fix another issue where we were assuming that component portals can only have one root node. This is true for most cases, except for when a sibling is inserted through
ViewContainerRef.Finally, these changes add a
detectChangescall before moving the contents of a component portal for consistency between portals. Previously we were only doing in for template portals.Fixes #20343.